Code review comment for lp:~jcsackett/launchpad/registry-errors-649836

Revision history for this message
j.c.sackett (jcsackett) wrote :

>> @@ -59,6 +56,7 @@
>> IHasBugs,
>> IHasOfficialBugTags,
>> )
>> +from lp.registry.errors import NoSuchDistroSeries
>
>
>
> It looks like we could use a separate file for special form fields,
> since DistroSeriesNameField needs NoSuchDistroSeries, but we lose the
> benefit of moving that exception to lp.registry.errors, if we are just
> going to import it. Can you open a bug for that?

I can and will.

>> from lp.code.interfaces.hasrecipes import IHasRecipes
>> +from lp.registry.errors import (
>> + PrivatePersonLinkageError,
>> + )
>
>
> Can you run utilities/format-imports on all the files you touched
> in this branch? This import will fit on a single line.

Done.

Thanks for the review, Edwin.

« Back to merge proposal