Merge lp:~jcsackett/launchpad/unknown-blueprints-service-597738-2 into lp:launchpad
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | j.c.sackett | ||||||||
Approved revision: | no longer in the source branch. | ||||||||
Merged at revision: | 11631 | ||||||||
Proposed branch: | lp:~jcsackett/launchpad/unknown-blueprints-service-597738-2 | ||||||||
Merge into: | lp:launchpad | ||||||||
Prerequisite: | lp:~jcsackett/launchpad/series-need-usage-attributes-643902 | ||||||||
Diff against target: |
120 lines (+23/-48) 2 files modified
lib/lp/blueprints/templates/unknown-specs.pt (+22/-48) lib/lp/registry/tests/test_service_usage.py (+1/-0) |
||||||||
To merge this branch: | bzr merge lp:~jcsackett/launchpad/unknown-blueprints-service-597738-2 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Edwin Grubbs (community) | code | Approve | |
Review via email: mp+36242@code.launchpad.net |
Commit message
Cleans up unknown-specs template; template used to use a nasty python conditional and didn't have norobots; nofollow.
Description of the change
Summary
=======
Cleans up the unknown-specs template in blueprints by leveraging work in a branch that adds usage enums to product and distribution series.
Proposed Fix
============
Remove nasty python conditionals from the template and use the now added attributes.
Implementation details
=======
As in proposed fix.
Tests
=====
bin/test -m lp.blueprints
Demo and Q/A
============
Open http://
Lint
====
Output:
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
20: not well-formed (invalid token)
./lib/lp/
417: E301 expected 1 blank line, found 2
458: E301 expected 1 blank line, found 0
./lib/lp/
364: E301 expected 1 blank line, found 2
708: E301 expected 1 blank line, found 2
Errors are a result of lint's comment/blank line issue.
Output mucked up by merged precondition branch.
Hi JC,
This branch looks good.
-Edwin