Code review comment for lp:~jcsackett/launchpad/unknown-blueprints-service-597738

Revision history for this message
Curtis Hovey (sinzui) wrote :

Gentleman, I think the reviewers and developers need to consider why we are making this change, and what we are really changing.

Our goal is to communicate to the user where certain kinds of activities are performed--which site does the user need to visit to complete his goal. Launchpad blueprints is a branded service that provides specifications and documentation. The page needs to be talking about "specifications and documentation" because other sites, most often wikis, do not use the term blueprints. We want to allow the users to provide a URL when they choose external (maybe repurpose the wiki field). The page is not really stating that Launchpad Blueprints allows the user to track specifications and documentation...I see no reason why I would turn the feature on since it does not have a sentence stating the basics of what it is for. Specification itself may be too technical. This app is essentially about planning and documenting features.

My other concern is about what has specifications--a SpecificationTarget. I reviewed the bugs branch a few days ago and saw only IProduct was supports well. A BugTarget may be a product, projectgroup, distribution, and distributionsourcepackage. I think these are also SpediciationTargets, so everyone needs to visit an example of each to ensure the message is correct and the actions that can be takes are presented. eg, a project group's use of an app is implicit in the settings of its products. I took a brief look at this branch in launchpad.dev and am pretty sure thunderbird is somewhat right, kubuntu, firefox and mozilla are wrong.

jcsackett, Salgado, take a look at the branch again from the perspective of kinds of users who are interested in feature planning.

review: Needs Fixing

« Back to merge proposal