+class MailingListSubscriptionControlsTestCase(TestCaseWithFactory):
+ """Tests to ensure the rendering of subscribe and unsubscribe
+ controls on the team page."""
PEP 257 states that a docstring has a single line synopses.
"""Verify the team index subscribe/unsubscribe to mailing list content."""
...
> === modified file 'lib/lp/registry/templates/team-portlet-mailinglist.pt'
> --- lib/lp/registry/templates/team-portlet-mailinglist.pt 2010-06-04 15:37:24 +0000
> +++ lib/lp/registry/templates/team-portlet-mailinglist.pt 2010-08-17 16:07:46 +0000
> @@ -19,10 +19,10 @@
> <strong>Policy:</strong>
> You must be a team member to subscribe to the team mailing list.
> <br/>
> - <tal:member condition="view/user_is_active_member">
> + <tal:member condition="view/userIsParticipant">
> <tal:can-subscribe-to-list
> condition="view/user_can_subscribe_to_list">
> - <a class="sprite add"
> + <a id="link.list.subscribe" class="sprite add"
This is not a valid CSS3 id use dashes, no dots, no underscores. We know that
zope and some of out code are making bad ids. We need to get the site ready
for the CSS3 standard.
Hi Jon.
This looks good to land after you have addressed my nitpick about the docstring and id.
> === added file 'lib/lp/ registry/ browser/ tests/test_ mailinglists. py' registry/ browser/ tests/test_ mailinglists. py 1970-01-01 00:00:00 +0000 registry/ browser/ tests/test_ mailinglists. py 2010-08-17 16:07:46 +0000
> --- lib/lp/
> +++ lib/lp/
...
+class MailingListSubs criptionControl sTestCase( TestCaseWithFac tory):
+ """Tests to ensure the rendering of subscribe and unsubscribe
+ controls on the team page."""
PEP 257 states that a docstring has a single line synopses. unsubscribe to mailing list content."""
"""Verify the team index subscribe/
...
> === modified file 'lib/lp/ registry/ templates/ team-portlet- mailinglist. pt' registry/ templates/ team-portlet- mailinglist. pt 2010-06-04 15:37:24 +0000 registry/ templates/ team-portlet- mailinglist. pt 2010-08-17 16:07:46 +0000 Policy: </strong> "view/user_ is_active_ member" > "view/userIsPar ticipant" > subscribe- to-list "view/user_ can_subscribe_ to_list" > list.subscribe" class="sprite add"
> --- lib/lp/
> +++ lib/lp/
> @@ -19,10 +19,10 @@
> <strong>
> You must be a team member to subscribe to the team mailing list.
> <br/>
> - <tal:member condition=
> + <tal:member condition=
> <tal:can-
> condition=
> - <a class="sprite add"
> + <a id="link.
This is not a valid CSS3 id use dashes, no dots, no underscores. We know that
zope and some of out code are making bad ids. We need to get the site ready
for the CSS3 standard.