Code review comment for lp:~jelmer/bzr/colo-urls

Revision history for this message
Robert Collins (lifeless) wrote :

Ok, some notes:
 - if we have to edit the url before passing to transport, transport isn't supporting segment parameters properly - need some tests on that layer

 e.g. opening foo and foo,name=bar should get two equal transports. (except for parameters we decide transports should support - e.g. passive ftp might be one (though we have a syntax for that already)

So - further discussion:
 - Transport is our 'access a url' abstraction; it should take care of getting parameters parsed, exposing the parsed parameters to BzrDir.open_from_transport, and so on.
 - BzrDir should get the default branch from the transport parameters.
 - other code shouldn't need to change for this part of the conversion
 - we should end up being able to open '/foo/bar,name=gam' as a result ! (without changing all the higher layers).

review: Needs Fixing

« Back to merge proposal