Code review comment for lp:~jelmer/bzr/foreign-tests

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij wrote:
> Thanks for the review.
>
>> However, I think I would tweak a few things differently anyway.
>>
>> 1) It should probably be called "per_foreign" rather than "foreign"
> Wouldn't this mean we'd need per_foreign_branch, per_foreign_repository, per_foreign_branch_format, etc?
>
> Cheers,
>
> Jelmer

It depends if you think you are going to have more than one branch type
per foreign type, and more than one repo type, etc.

At the moment, neither git nor hg have allowed anything of that sort.
I'm not sure that svn has either.

In which case adding the extra permutations doesn't seem to gain much of
anything.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqFcJ4ACgkQJdeBCYSNAAMNzwCeIdhUQ5KvUi/8GNUgDyV1TayB
930An1GpW6cnBnBKvC2dwTWPuw4UY73s
=wjYm
-----END PGP SIGNATURE-----