Code review comment for lp:~jelmer/bzr/mkdir-p

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

> Good job picking up this.
>
> Amusing (though... not actually related), I've just been reading this in the
> make documentation: "For example, don't use ‘mkdir -p’, convenient as it may
> be, because a few systems don't support it at all and with others, it is not
> safe for parallel execution."
:-) I guess the same will be true for older versions of bzr...

> Style nit with the code, rather than complicating the simple run() method with
> nested functions that don't need to close over anything, I'd prefer if they
> were @staticmethod or something on the class.
Fixed.

« Back to merge proposal