Code review comment for lp:~jelmer/bzr/split-subsegment
Revision history for this message
| Jelmer Vernooij (jelmer) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On Mon, 2010-04-19 at 00:54 +0000, Robert Collins wrote:
> I think you would be better calling this 'segment parameters' or something
> like that, and it should take a dict rather than plain strings, I think.
Thanks for the review.
I'm not I understand having a dict rather than a list. What would you
want the dict to use as keys or values?
Cheers,
Jelmer