Merge lp:~jelmer/launchpad-cscvs/converted-from into lp:launchpad-cscvs

Proposed by Jelmer Vernooij
Status: Merged
Merged at revision: not available
Proposed branch: lp:~jelmer/launchpad-cscvs/converted-from
Merge into: lp:launchpad-cscvs
Diff against target: 37 lines
2 files modified
modules/svn_oo/Revision.py (+5/-1)
modules/svn_oo/tests/test_revision.py (+2/-1)
To merge this branch: bzr merge lp:~jelmer/launchpad-cscvs/converted-from
Reviewer Review Type Date Requested Status
Paul Hummer (community) Approve
Review via email: mp+13542@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This makes svn2bzr set the 'converted-from' property as described in http://bazaar-vcs.org/ConvertedRevisionProperty

Revision history for this message
Paul Hummer (rockstar) wrote :

Are you going to need someone to land this for you?

review: Approve
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

> Are you going to need someone to land this for you?
Yes, please.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

> > Are you going to need someone to land this for you?
> Yes, please.
.. and thanks for the review :-)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'modules/svn_oo/Revision.py'
--- modules/svn_oo/Revision.py 2009-06-16 08:37:12 +0000
+++ modules/svn_oo/Revision.py 2009-10-18 19:15:22 +0000
@@ -21,6 +21,8 @@
21from svn_oo.SourceIterator import SourceIterator21from svn_oo.SourceIterator import SourceIterator
22import svn_oo.util22import svn_oo.util
2323
24import urllib
25
2426
25class RevisionNumberError(Exception):27class RevisionNumberError(Exception):
26 """Revision.number() cannot be used on this Revision instance.28 """Revision.number() cannot be used on this Revision instance.
@@ -103,7 +105,9 @@
103 uuid = svn_wc_entry(self.path, adm, True).uuid105 uuid = svn_wc_entry(self.path, adm, True).uuid
104 return {'cscvs-svn-branch-path': self.repoPrefix(),106 return {'cscvs-svn-branch-path': self.repoPrefix(),
105 'cscvs-svn-repository-uuid': uuid,107 'cscvs-svn-repository-uuid': uuid,
106 'cscvs-svn-revision-number': str(self.rev.number)}108 'cscvs-svn-revision-number': str(self.rev.number),
109 'converted-from': 'svn %s:%d:%s\n' % (uuid, self.rev.number, urllib.quote(self.repoPrefix().strip("/")))
110 }
107111
108 def get_log(self):112 def get_log(self):
109 """My raw log, as an utf8 encoded str."""113 """My raw log, as an utf8 encoded str."""
110114
=== modified file 'modules/svn_oo/tests/test_revision.py'
--- modules/svn_oo/tests/test_revision.py 2009-06-16 08:24:20 +0000
+++ modules/svn_oo/tests/test_revision.py 2009-10-18 19:15:22 +0000
@@ -137,7 +137,8 @@
137 self.assertEqual(137 self.assertEqual(
138 {'cscvs-svn-branch-path': 'modulefile1',138 {'cscvs-svn-branch-path': 'modulefile1',
139 'cscvs-svn-repository-uuid': uuid,139 'cscvs-svn-repository-uuid': uuid,
140 'cscvs-svn-revision-number': '1'},140 'cscvs-svn-revision-number': '1',
141 'converted-from': 'svn %s:1:modulefile1\n' % uuid},
141 self.rev1().get_extra_revprops())142 self.rev1().get_extra_revprops())
142143
143 def testGetDate(self):144 def testGetDate(self):

Subscribers

People subscribed via source and target branches