Code review comment for lp:~jelmer/launchpad/506256-remove-popen

Revision history for this message
Brad Crittenden (bac) wrote :

Jelmer this branch looks ok. As I mentioned on IRC I'm getting test failures. I'm re-running them now and will paste the results when they are done.

Other than that I only find this one typo that needs fixing.

typo: s/nonexisting/nonexistent

Keeping the branch unapproved until the tests are sorted out.

review: Needs Information (code)

« Back to merge proposal