Just two nitpicks:
- As discussed on IrC, we dont need the new symlinks lib/deb822.py and lib/debian
- line 41 of the diff (doc string of class Version) contains trailing spaces. Please remove them
"make lint" has a few more complaints:
./lib/lp/archivepublisher/debversion.py
25: E302 expected 2 blank lines, found 0
25: E701 multiple statements on one line (colon)
26: E302 expected 2 blank lines, found 0
26: E701 multiple statements on one line (colon)
27: E302 expected 2 blank lines, found 0
27: E701 multiple statements on one line (colon)
28: E302 expected 2 blank lines, found 0
28: E701 multiple statements on one line (colon)
33: W291 trailing whitespace
47: E301 expected 1 blank line, found 0
51: W602 deprecated form of raising exception
56: W602 deprecated form of raising exception
60: W602 deprecated form of raising exception
62: W602 deprecated form of raising exception
71: W602 deprecated form of raising exception
33: Line has trailing whitespace.
Hi Jelmer,
the branch looks good.
Just two nitpicks:
- As discussed on IrC, we dont need the new symlinks lib/deb822.py and lib/debian
- line 41 of the diff (doc string of class Version) contains trailing spaces. Please remove them
"make lint" has a few more complaints:
./lib/lp/ archivepublishe r/debversion. py
25: E302 expected 2 blank lines, found 0
25: E701 multiple statements on one line (colon)
26: E302 expected 2 blank lines, found 0
26: E701 multiple statements on one line (colon)
27: E302 expected 2 blank lines, found 0
27: E701 multiple statements on one line (colon)
28: E302 expected 2 blank lines, found 0
28: E701 multiple statements on one line (colon)
33: W291 trailing whitespace
47: E301 expected 1 blank line, found 0
51: W602 deprecated form of raising exception
56: W602 deprecated form of raising exception
60: W602 deprecated form of raising exception
62: W602 deprecated form of raising exception
71: W602 deprecated form of raising exception
33: Line has trailing whitespace.
Could you plase fix this?