Launchpad itself

Code review comment for lp:~jelmer/launchpad/600153-main-archive-builds-on-restricted

  1. 600153-main-archive-builds-on-restricted
  2. Merge into devel
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Reviewed per IRC. Notes:

 * Run "make lint" before you submit the MP!

 * No seriously, run "make lint"!

 * Pass exception message to exception constructor. Putting it in _fmt seems unsafe.

 * There's no need for proper docstrings on test methods.

 * capitalize and punctuate error strings

Otherwise, you're good to go.

Jeroen

review: Approve

« Back to merge proposal