Code review comment for lp:~jelmer/launchpad/600153-qafix

Revision history for this message
Brad Crittenden (bac) wrote :

Hi Jelmer,

Please sort your import items alphabetically.

Based on the QA report this change looks good (though I can't claim deep enough knowledge to know for sure).

You didn't add or modify any tests for this change. Is this fix not testable? Would an appropriate test on the original branch have avoided the second round?

review: Needs Information (code)

« Back to merge proposal