Launchpad itself

Code review comment for lp:~jelmer/launchpad/634045-lp-bugs-fixed

  1. 634045-lp-bugs-fixed
  2. Merge into devel
Revision history for this message
Abel Deuring (adeuring) wrote :

Hi Jelmer,

a nice branch, just one nitpick:

> - def createWaitingAcceptancePackage(self, distroseries, archive=None,
> + def createWaitingAcceptancePackage(self, distroseries, archive=None,
> sourcename=None):

Our style guide says that this should either be

    def createWaitingAcceptancePackage(self, distroseries, archive=None,
                                       sourcename=None):
or

    def createWaitingAcceptancePackage(
        self, distroseries, archive=None, sourcename=None):

review: Approve (code)

« Back to merge proposal