Code review comment for lp:~jelmer/launchpad/bug499115

Revision history for this message
Henning Eggers (henninge) wrote :

Thank you for adding this simple fix. I still think this corner case should be tested in a unit test. To make testing possible, I'd suggest that you split out the lines under "# Retrieve log file content" into its own method "get_logfile_content" and add tests for it to test/test_bulidbase.py.

review: Needs Fixing (code)

« Back to merge proposal