Code review comment for lp:~jelmer/launchpad/buildd-trivial

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

<lamont> jelmer: why break package into prepare and package?
<lamont> jelmer: other than that question, +1 from me
<lamont> jelmer: and actually, we should bzr ignore all of launchpad-files, not just tachandler.py
<jelmer> lamont: Since I install launchpad-buildd locally I'd like to build a binary package, not a source package. Splitting out prepare allows me to run prepare just once and then modify / debuild as necessary.
<jelmer> lamont: I'll update bzrignore to just ignore all files in launchpad-files.
<lamont> ah, ok
...
<jelmer> lamont: diff is here: http://pastebin.ubuntu.com/476947/
<lamont> jelmer: +1

« Back to merge proposal