Code review comment for lp:~jelmer/launchpad/buildmaster-enums

Revision history for this message
Brad Crittenden (bac) wrote :

Nice, big, boring branch Jelmer. Thanks for doing it.

We talked about the local import. Fix it if you can with minimal fuss.

Also, many place you have:

+from lp.buildmaster.enums import (
+ BuildStatus,
+ BuildFarmJobType,
+ )

which needs to be reordered for proper alphabetizing.

review: Approve (code)

« Back to merge proposal