Code review comment for lp:~jelmer/launchpad/noversion

Hi Jelmer,

overall, your changes look good. But I get a test failure when I run ./bin/test -t test_debversion:

Failure in test testNullRevisionIsZero (lp.archivepublisher.tests.test_debversion.VersionTests)
Traceback (most recent call last):
  File "/usr/lib/python2.5/unittest.py", line 260, in run
    testMethod()
  File "/home/abel/canonical/lp-branches/review-jelmer/lib/lp/archivepublisher/tests/test_debversion.py", line 132, in testNullRevisionIsZero
    self.assertEquals(Version("1.0"), Version("1.0-0"))
  File "/usr/lib/python2.5/unittest.py", line 334, in failUnlessEqual
    (msg or '%r != %r' % (first, second))
AssertionError: Version('1.0') != Version('1.0-0')

Are you sure that the new, more strict, comparison does not have any bad side effects?

(And if

    Version('1.0') != Version('1.0-0')

works in Launchpad, I think you can remove this test.)