Code review comment for lp:~jelmer/launchpad/noversion
Revision history for this message
| Abel Deuring (adeuring) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
On 12.03.2010 11:43, Jelmer Vernooij wrote:
> This test already existed, I've just changed it to use assertEquals.
Right, but you changed the implemention of the tested class, so this is
a genuine test failure ;)
>
> Older versions of Launchpad also had this behaviour and it's required by Debian policy. It looks like older versions of python-debian considered 1.0 < 1.0-0.
OK. But the is question why this "relaxed equality comparison" was
introduced and even tested, and if we can remove it again.
>
> I'll see if we can include python-debian in Launchpad or provide backports of python-debian so we're sure we have a working version.