Code review comment for lp:~jelmer/meta-lp-deps/lintian

Hi Max,

On Tue, 2010-08-10 at 13:23 +0000, Max Bowsher wrote:
> Review: Needs Fixing On Standards-Version ... is anyone checking or
> caring whether we are compliant? On never-for-distro packages, I
> sometimes set Standards-Version to 0. If we are updating it, there
> should be words in the debian/changelog entry stating that no changes
> were required, or what changes were needed.
It means we can use the various tools for quality assurance (like
lintian) without too much noise.

> On the description changes... is "meta-package", hyphenated, the standard? I've only seen it hyphenless.
It's meta-package (with hyphen). See http://lintian.debian.org/tags/empty-binary-package.html

> On the copyright file changes... the debian/changelog declares the package dates back to 2005 - from what source to you derive 2009-2010 ?
I had based it on the output of "bzr log". The first revision is from
2009. I've updated the copyright file to use 2005.

> On the ${misc:Depends} addition... harmless and pacifies lintian,
> though a bit redundant in a metapackage. Might be better to place it
> on a final line on its own, so it doesn't keep getting involved in the
> diffs when people add packages.
Clearly we need a custom merger/differ for Debian control files in
Bazaar. :-)

Anyway, updated.

Cheers,

Jelmer