Merge lp:~jelmer/tribunal/view-subunit into lp:~mbp/tribunal/view-subunit-broken

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Martin Pool
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~jelmer/tribunal/view-subunit
Merge into: lp:~mbp/tribunal/view-subunit-broken
Diff against target: 56 lines (+21/-7)
1 file modified
bin/tribunal-subunit (+21/-7)
To merge this branch: bzr merge lp:~jelmer/tribunal/view-subunit
Reviewer Review Type Date Requested Status
Martin Pool Approve
Jonathan Lange Pending
Review via email: mp+18006@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This merges Roberts changes (and resolves the conflicts) and fixes a few unused imports.

Revision history for this message
Martin Pool (mbp) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/tribunal-subunit'
--- bin/tribunal-subunit 2010-01-25 15:31:21 +0000
+++ bin/tribunal-subunit 2010-01-25 15:43:14 +0000
@@ -16,16 +16,16 @@
16except ImportError:16except ImportError:
17 pass17 pass
1818
19from pprint import pformat
20import sys19import sys
2120
22import gtk21import gtk
23import pango22import pango
2423
25from testtools import (24try:
26 MultiTestResult,25 import testrepository.repository.file
27 TestResult,26except ImportError:
28 )27 testrepository = None
28
29from subunit import TestProtocolServer29from subunit import TestProtocolServer
30from subunit.test_results import TestResultFilter30from subunit.test_results import TestResultFilter
3131
@@ -35,7 +35,6 @@
35from tribunal.eventloop import GtkLoop35from tribunal.eventloop import GtkLoop
36from tribunal.view import (36from tribunal.view import (
37 load_glade,37 load_glade,
38 TribunalWindow,
39 )38 )
4039
4140
@@ -257,7 +256,22 @@
257 glade_xml.signal_autoconnect(self)256 glade_xml.signal_autoconnect(self)
258257
259 self._window.show_all()258 self._window.show_all()
260 self._window.load_from_subunit_stream(file(argv[1], 'rt'))259 if len(argv) < 2:
260 stream = None
261 # Try for testrepository source
262 if testrepository is not None:
263 factory = testrepository.repository.file.RepositoryFactory()
264 try:
265 repo = factory.open('.')
266 except IOError:
267 stream = None
268 else:
269 stream = repo.get_test_run(repo.latest_id()).get_subunit_stream()
270 if stream is None:
271 stream = sys.stdin
272 else:
273 stream = file(argv[1], 'rb')
274 self._window.load_from_subunit_stream(stream)
261275
262 self._event_loop.start()276 self._event_loop.start()
263277

Subscribers

People subscribed via source and target branches

to all changes: