Code review comment for lp:~jjacobs/methanal/better-submission-failures

Revision history for this message
Jonathan Jacobs (jjacobs) wrote :

> I don't really have too much to say about this; it seems like a step in the
> right direction. As a general point of application design, form submission
> shouldn't fail, but in the case where something goes wrong, the user shouldn't
> be lead to think that the operation they were attempting to perform succeeded
> when it didn't.

One of the scenarios where this comes up is where an error design to occur does. For example, submitting a form that results in some external API call that fails for some reason (authentication failed, invalid/missing data, etc.)

Perhaps this case shouldn't be a submission failure, but for now it is. I'd be interested to hear any further ideas on this topic.

« Back to merge proposal