Code review comment for lp:~jjacobs/methanal/verified-password-input

Revision history for this message
Jonathan Jacobs (jjacobs) wrote :

> 1. The docstring in TestView.js on line 834 is an incomplete sentence and is
> slightly unclear.

Oops, sorry.

> 2. This is a matter of preference really, but I think it would be clearer if
> the variable c in View.js in lines 1828-1831 were renamed to 'criterion'

It was probably renamed to reduce it's width and then something else happened that stopped that from mattering.

« Back to merge proposal