Code review comment for lp:~jjed/bzr/xdg_basedir_compliance

Revision history for this message
Robert Collins (lifeless) wrote :

I really don't like moving user edited files around without warning; even worse is leaving the old ones in place: we'll have to deal with questions like:

"I edited ~/.bazaar/bazaar.conf" and *it didn't work*. Help.

Certainly, your code is part of migrating, but I don't think we can or should merge a change like this until we've got all the ducks in a row: consensus on changing [perhaps mail the mailing list to discuss it], documentation updates ready to roll, some assessment about the impact on users in existing distribution releases (e.g. Lucid, supported for 3 years) if they run a release from our PPA and then switch back to their distro version - or worse if they are running on a NFS mounted home with different versions of bzr on two machines.

All in all I'm really not convinced that migrating is worth the impact on our users - we have a huge amount of documentation about where our config files are, that is out there in blog posts and so on. I appreciate the uniformity that the XDG specification offers, so I want to be clear that I'm not rejecting this patch overall, but I do think we need to defer it until these other issues are addressed.

Alternatively, you could make it ready-to-go, but not actually enabled, so that the branch is merged but has no impact until we're ready to migrate.

If you want to do that, please address Andrew's comments and then move the status of this proposal back to needs-review, or alternatively click 'resubmit' (after addressing Andrew's comments).

review: Needs Resubmitting

« Back to merge proposal