Code review comment for lp:~jkakar/bzr/custom-project-name

Revision history for this message
Robert Collins (lifeless) wrote :

I have only vicariously reviewed so far (by reading John's review). I'll
do a deeper review after these issues are sorted.

firstly I don't think we need indirection on the ProgramInfo

statically initialise it

program_info = ProgramInfo()

And if someone needs to replace it they can. See ui.ui_factory and how
its managed to see this in practice today.

On Wed, 2009-09-23 at 14:21 +0000, John A Meinel wrote:
> class cmd_alias(bzrlib.builtins.cmd_alias):
> """New doc string with my program name."""
>
> You'll likely need to do the inheritance anyway, to inject whatever
> changes you need to do to get the aliases to show up in your config
> file, rather than in ours.
>
> So *I* personally don't like the change from "bzr => %(program-name)s"
> in the help text. I'm not going to veto it, but I'd at least like us to
> discuss it before we merge it.

I too have a concern about this. I think its ok for a small number of
commands, but for many it would be very tedious - and I really don't
know how many are even vaguely suitable to be used verbatim.

-Rob

« Back to merge proposal