Code review comment for lp:~jkakar/bzr/custom-project-name

2009/9/24 John A Meinel <email address hidden>:
> Martin- I asked for your specific review to get another opinion on changing help text for stuff like "cmd_alias" to be:
>
>  %(program-name)s alias ...

In general I think separating infrastructure from bazaar-specific use
of it is good.

I think the help text is fine. I would prefer and recommend that the
variables used in the dict be valid identifiers in python, ie
program_name not a hyphen. It doesn't make a big difference in this
patch but in general it helps that you can pass them as kwargs etc.

It seems like there should be a brief description in the developer
docs of why we do this.

This text is inserted into the autogenerated user reference so you
should check that the substitution is done correctly there.

The ProgramInfo stuff is a bit distressingly large for what amounts to
two global variables set at startup time to constant values. (Isn't
it?) It's more like a Java style, where in Python it would be more
idiomatic and simple to just have a global variable that either holds
the value or a callable for the value...

I wonder if this will break any plugins or commands that happen to
have % is their help string?

I don't think this would be worth the risk for 2.0.

--
Martin <http://launchpad.net/~mbp/>