Code review comment for lp:~jkakar/launchpadlib/fake-launchpad

Revision history for this message
Gavin Panella (allenap) wrote :

The signatures for some methods has changed in launchpadlib, so the
fakes are a little out of date.

For those methods with optional arguments I think it's okay if the
fake accepts a subset of the arguments - it will still be useful - but
they still must be in-sync with the real methods. We could add some
tests to automatically compare using inspect.getargspec.

If this small amount of work is done I think this code should be in
launchpadlib rather than going stale outside of it. Even if it's not
perfect (when are fakes perfect?) I think it's useful. It also
self-selects contributors: anyone using it will be perfectly capable
of contributing to it, and motivated to do so.

« Back to merge proposal