Code review comment for lp:~jml/bzr/allow-writes-change-84659

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jonathan Lange wrote:
> Jonathan Lange has proposed merging lp:~jml/bzr/allow-writes-change-84659 into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
>
> This branch changes the 'serve' command to take --allow-anonymous-write-access instead of --allow-writes, which it deprecates.
>

So... I'm a bit iffy on this. For example when using "bzr+ssh" we do:

ssh host bzr serve --inet --allow-writes --directory=/

It doesn't really fit to do:

ssh host bzr serve --inet --allow-anonymous-writes --directory=/

1) It will break launchpad (until the changes are merged, and the ssh
server updated to allow that string)
2) It *is* anonymous, except that you've already authenticated...

I understand the desire behind being clear about it for "bzr serve" to
bring up the http/bzr:// access. I just worry about some of the fallout.

(I'm not blocking, just bringing up the discussion.)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpPorEACgkQJdeBCYSNAAM4BgCfTrNMochm9renXoWBE0Jgyhib
BhEAoL5VPhldTYA+5DhR6JHlo/9ATxI+
=jAd+
-----END PGP SIGNATURE-----