Code review comment for lp:~jml/bzr/allow-writes-change-84659

Revision history for this message
Vincent Ladeuil (vila) wrote :

>>>>> "Andrew" == Andrew Bennetts <email address hidden> writes:

<snip/>

    Andrew> Complicated rules for a command along the lines of
    Andrew> “--auth=... is mandatory unless --inet is provided”
    Andrew> feel a bit messy to me. Maybe what's needed is
    Andrew> separate commands for “start a TCP server” and “start
    Andrew> a bzr+ssh” server? I'm not sure that that is the
    Andrew> best answer, but the different requirements for
    Andrew> typical bzr+ssh vs. TCP are a bit suggestive of it.
    Andrew> And we're planning on adding --http to the mix...

I agree with the feeling. I'd prefer several high level commands
with their own options that all use the same helper than a single
high-level command with many options for which some combinations
make no sense.

« Back to merge proposal