Code review comment for lp:~jml/bzr/lp-login-oauth-2

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jonathan Lange wrote:
> On Thu, Dec 10, 2009 at 9:47 PM, Alexander Belchenko <email address hidden> wrote:
>>> For what, exactly?
>> For py2exe and bzr.exe.
>
> I meant, using lazy_import for what?
>
> jml

If you use lazy_import it won't be detected by py2exe, and thus won't
try to require you to have launchpadlib available to build the installer.

That said, I'd defer that until we actually try to build an installer
once this patch has landed.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkshcFIACgkQJdeBCYSNAAMxXQCeOFarlbYEkrLvVdjgNbVTIyZU
CFQAnixpcuD7RJiGtRSui1ZKZMKpTtFR
=5bpz
-----END PGP SIGNATURE-----

« Back to merge proposal