Code review comment for lp:~jml/bzr/lp-login-oauth-2

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jonathan Lange wrote:
> On Fri, Dec 11, 2009 at 9:06 AM, John A Meinel <email address hidden> wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Jonathan Lange wrote:
>>> On Thu, Dec 10, 2009 at 9:47 PM, Alexander Belchenko <email address hidden> wrote:
>>>>> For what, exactly?
>>>> For py2exe and bzr.exe.
>>> I meant, using lazy_import for what?
>>>
>>> jml
>> If you use lazy_import it won't be detected by py2exe, and thus won't
>> try to require you to have launchpadlib available to build the installer.
>>
>> That said, I'd defer that until we actually try to build an installer
>> once this patch has landed.
>>
>
> Sorry if I'm being a bit dense here, but *where* should I use
> lazr_import? Which import should I change? All of them? The one in the
> cmd_launchpad_mirror.run method?
>
> jml

It would be the one in _get_lp_api, but I'm not actually advocating that
you do so until we've determined it is really necessary.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkshwQwACgkQJdeBCYSNAANtAQCfWH3J9+Drq+dNXQdorCcN7sd0
XAsAoITrsVue6hFzBkeClD7ZevfbdXjW
=Wj76
-----END PGP SIGNATURE-----