Code review comment for lp:~jml/bzr/lp-login-oauth

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jonathan Lange wrote:
> Thanks for the comments John. I think they were made on an out-of-date diff, since the one I'm looking at doesn't incorporate my most recent changes.
>
> While I slept...
>
> <spiv> jml: are you sure you pushed? I don't see any new revisions
> <spiv> jml: oh, it's stacked on the old, non-rich-root, bzr trunk, so boom: https://code.edge.launchpad.net/~jml/bzr/lp-login-oauth
> <spiv> jml: I think bzr and launchpad can take equal credit for that snafu ;)

Most likely. Do you have something updated then? As the diff I still see
is out of date.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksgDVoACgkQJdeBCYSNAAO2dwCeJjkTlKv39Iy4IfMmhBJpeqgH
17QAnils3Rj/jFIodZlWV2A+DmSdSit9
=1IGb
-----END PGP SIGNATURE-----

« Back to merge proposal