Launchpad itself

Merge lp:~jml/launchpad/apidoc-dir into lp:launchpad

  1. apidoc-dir
  2. Merge into devel
Proposed by Jonathan Lange
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merged at revision: 11056
Proposed branch: lp:~jml/launchpad/apidoc-dir
Merge into: lp:launchpad
Diff against target: 33 lines (+3/-3)
2 files modified
.bzrignore (+1/-0)
Makefile (+2/-3)
To merge this branch: bzr merge lp:~jml/launchpad/apidoc-dir
Reviewer Review Type Date Requested Status
Jelmer Vernooij (community) code Approve
Māris Fogels Pending
Review via email: mp+28432@code.launchpad.net

Commit message

Remove lib/canonical/launchpad/apidoc. Generate it in make apidoc.

Description of the change

This branch deletes the apidoc directory, instead making it whenever the API docs are built. This means there's less auto-generatable stuff in the tree, which can only help those of us who have trouble navigating the code base.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This lacks adding a .bzrignore entry for the api doc directory as we discussed on IRC.

review: Approve (code)
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

> This lacks adding a .bzrignore entry for the api doc directory as we discussed
> on IRC.
... and I hit enter a bit too early. What I meant to say was I'm happy to see this land if .bzrignore is updated.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '.bzrignore'
--- .bzrignore 2010-05-27 07:12:50 +0000
+++ .bzrignore 2010-06-24 17:22:28 +0000
@@ -68,3 +68,4 @@
68lp.sfood68lp.sfood
69apidocs69apidocs
70twistd.pid70twistd.pid
71lib/canonical/launchpad/apidoc
7172
=== modified file 'Makefile'
--- Makefile 2010-06-11 18:57:02 +0000
+++ Makefile 2010-06-24 17:22:28 +0000
@@ -61,8 +61,7 @@
61$(API_INDEX): $(BZR_VERSION_INFO)61$(API_INDEX): $(BZR_VERSION_INFO)
62 mkdir -p $(APIDOC_DIR).tmp62 mkdir -p $(APIDOC_DIR).tmp
63 LPCONFIG=$(LPCONFIG) $(PY) ./utilities/create-lp-wadl-and-apidoc.py "$(WADL_TEMPLATE)"63 LPCONFIG=$(LPCONFIG) $(PY) ./utilities/create-lp-wadl-and-apidoc.py "$(WADL_TEMPLATE)"
64 mv $(APIDOC_DIR).tmp/* $(APIDOC_DIR)64 mv $(APIDOC_DIR).tmp $(APIDOC_DIR)
65 rmdir $(APIDOC_DIR).tmp
6665
67apidoc: compile $(API_INDEX)66apidoc: compile $(API_INDEX)
6867
@@ -340,7 +339,7 @@
340 $(RM) -r lib/mailman339 $(RM) -r lib/mailman
341 $(RM) -rf lib/canonical/launchpad/icing/build/*340 $(RM) -rf lib/canonical/launchpad/icing/build/*
342 $(RM) -r $(CODEHOSTING_ROOT)341 $(RM) -r $(CODEHOSTING_ROOT)
343 $(RM) $(APIDOC_DIR)/wadl*.xml $(APIDOC_DIR)/*.html342 $(RM) -rf $(APIDOC_DIR)
344 $(RM) -rf $(APIDOC_DIR).tmp343 $(RM) -rf $(APIDOC_DIR).tmp
345 $(RM) $(BZR_VERSION_INFO)344 $(RM) $(BZR_VERSION_INFO)
346 $(RM) +config-overrides.zcml345 $(RM) +config-overrides.zcml
347346
=== removed directory 'lib/canonical/launchpad/apidoc'