Code review comment for lp:~jml/launchpad/code-to-branches

Revision history for this message
Michael Nelson (michael.nelson) wrote :

> This branch changes the "Code" tab to be a "Branches" tab. It also changes the
> "launchpad usage" text to say, "Uses Launchpad for Answers and Branches".
>
> None of the changes are very surprising, I think.

Hi Jonathan,

Thanks for getting this done!

I think the main issue is conflicts with other RC-mp's... for example,
my own one at:

https://code.edge.launchpad.net/~michael.nelson/launchpad/sprint-index-should-hide-heading-db-devel/+merge/12284

adds a print_location call to a test. What's the best way to solve it?
I can obviously update my branch to expect 'Branches' and pre-empt the
failure - but I'd need to be sure that yours is landing at the same time...
or perhaps you merge any other of the branches on the CRB that use
print_location (maybe mine's the only one).

Anyway, I'll update CRB so that this is obvious.

--
Michael

review: Approve (code)

« Back to merge proposal