Code review comment for lp:~jml/launchpad/different-ec2-mail

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Nice to see the class structure rearranged and great to see much more test coverage.

As mentioned on IRC, two minor points:

<jelmer> jml: is there any reason you use Branch.open_containing vs Branch.open ?
<jml> jelmer, I don't, it's preserved from the original. I reckon we should use Branch.open & would happily change the code.
<jelmer> jml: --not-really doesn't really explain to me what it's not doing. What about --no-tests or --test-setup-only ?
<jml> jelmer, I'm going to delete the whole thing. it's buggy anyway

With that in mind, r=me.

review: Approve (code)

« Back to merge proposal