Code review comment for lp:~jml/launchpad/git-and-hg
Revision history for this message
| Jonathan Lange (jml) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On Fri, Jun 25, 2010 at 9:27 PM, Jonathan Lange <email address hidden> wrote:
> On Fri, Jun 25, 2010 at 9:19 PM, Robert Collins
> <email address hidden> wrote:
>> Just wanted to mention that it seems a little weird to manually
>> enumerate a list that we also have as a selector in the system.
>> Couldn't we list-and-stringify?
>>
>
> Patches accepted.
>
Which is to say, you're right and that would be a better approach.
However, I made the trade-off at the time of fixing a simple bug as
soon as I noticed it, and have no personal motivation to continue
improving this particular part of Launchpad right now.
jml