Code review comment for lp:~jml/launchpad/package-permission-love
Revision history for this message
| Julian Edwards (julian-edwards) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On Tuesday 01 September 2009 14:15:16 Celso Providelo wrote:
> The only comment I have is about the new control variable added in
> STP.getPubSource(). Why would you ever need to create an source
> publication that was *never* uploaded and doesn't contain any file ?
> It will look like a source imported by 'gina' but with no files.
>
> I suppose you are trying to avoid hitting the librarian and it will
> certainly speed you test up as long as the logic doesn't need that
> logic, but I don't think those implication are clear in the method
> docstring as they should.
Right, it should be clearer about the implications.
But I feel it's the right thing to have in the majority of tests. We want
them to be as skinny and focused as possible. Introducing packageupload
creation in some cases causes the need for dbuser switching, which is really
horrible to have in the middle of a doctest.