Code review comment for lp:~jml/launchpad/package-permission-love

Jono,

You changes are great, thanks for working on it. Two small nitpicks, though.

1) If remove the change on STP I'd be happier, if you find time to move the features I pointed before (makeSPR, makeSPPH) to the factory itself you will my hero for the whole month ;)

2) Factory.makeGPGKey() cannot be used more than once, since GPGKey.fingerprint has to be globally unique (which makes a lot of sense in the real world, right ?) Can you fix this with the existing unique-string support we already have ?

Other than that, great! r=me