Code review comment for lp:~jml/launchpad/subunit-by-default
Revision history for this message
| Jonathan Lange (jml) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
= Purpose =
This branch is intended to make debugging of test failures on EC2 easier by providing subunit output and by providing better error messages.
It also changes the default behaviour of the 'ec2 test' command to run in headless mode, deletes the '--headless' option and creates a new '--attached' option that is the inverse of the old '--headless' option.
= Implementation =
Most of the command changes are fairly boring. The interesting changes are in ec2test-remote and testrunner.py
In ec2test-remote, I deleted the JS checker, which is no longer used. I also removed the regex-based mechanic for producing output summary.
Instead, the full output is produced via subunit and interpreted using a component from subunit that drives a Python standard library TestResult object. I made my own TestResult object that prints out errors and failures as they occur.
I also rejiggered the subprocess code to have less nesting. I think this has made the behaviour clearer.
Finally, the subunit output is attached to the failure email. The attachment should have the correct mime type and a useful filename.
= Testing =
I've done several test runs through ec2 at various stages of development, including the final stage.