Code review comment for lp:~jml/testtools/patch-310770

Revision history for this message
Robert Collins (lifeless) wrote :

On Wed, Aug 4, 2010 at 10:32 PM, Jonathan Lange <email address hidden> wrote:
> I don't like that.
>
> We have a really nice monkey-patching module in Twisted and it simply never gets used. The only thing that ends up being used is TestCase.patch.

Why does that happen, do you think?

I'd really like others to be able to use this outside of TestCase,
e.g. for fixtures, so I'd _really_ like the core to be
not-on-TestCase, it has no justification to be there; having glue for
it on TestCase I'm ambivalent but not keen on, but ok with as long as
it really is a one-liner.

-Rob

« Back to merge proposal