Code review comment for lp:~joel-auterson/ubuntu/maverick/ibus/newmenuname

1. .po files should be left alone, since you only modified the msgid, but did not adjust the corrponding msgstr. Means, you would introduce translation bugs. The .po files shipped in the package will be updated at package build time.

2. in lines 246 to 266 my eyes caught a string which also needs to be changed. In ubuntu we don't want the users to add those lines to the ~/.bashrc . Instead, users should run System -> Administration -> Language Support and set the "Keyboard input method" to "ibus". Then log out and in again. That's it.

3. I don't think that upstream will accept this patch, since IBus is only one input method framework out of many available. It's us who chose this one to be used as primary input method framework in Ubuntu. Therefore, for other distributions and users, the current strings may make more sense instead of the proposed changes. And usually users who install ibus packages, know what they are dealing with (mostly East Asian users). It's again Ubuntu which ships IBus by default and therefore want to tweak the menu entry and the description.