Code review comment for lp:~johndescs/ubuntu/lucid/gajim/merge-from-squeeze

Hi,

debian/control: you sohuld change the maintainer adresse to Ubuntu Developers <email address hidden>
debian/changelog: please target maverick (the actual development version).

Also the package FTBFS:
...
../config/py-compile: 120: python2.5: not found
make[3]: *** [install-gajimsrc1PYTHON] Error 127
make[3]: Leaving directory `/build/fabrice-gajim_0.13.4-1ubuntu1-amd64-jwS4vy/gajim-0.13.4/src'
make[2]: *** [install-am] Error 2
make[2]: Leaving directory `/build/fabrice-gajim_0.13.4-1ubuntu1-amd64-jwS4vy/gajim-0.13.4/src'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/build/fabrice-gajim_0.13.4-1ubuntu1-amd64-jwS4vy/gajim-0.13.4'
make: *** [common-install-impl] Error 2
dpkg-buildpackage: error: /usr/bin/fakeroot debian/rules binary gave error exit status 2

this is because the default python is 2.5 in Debian, but 2.6 in Ubuntu, and a patch may be required.

As soon as you get fixed this issues, please report a debdiff in the bug report.

Thanks,
Fabrice