Code review comment for lp:~johnf-inodes/bzr/serve-init

Revision history for this message
Andrew Bennetts (spiv) wrote :

I haven't read the script carefully, but the defaults look sane and well commented, and I assume the init.d script works as intended on Debian.

It seems like a useful thing to include in contrib/ too, so it looks good to me.

I'm not sure what the copyright assignment policy is for the contents of contrib, though. I suppose either:

 a) you should sign the agreement at <http://www.canonical.com/contributors> (if you haven't already) and put boilerplate "copyright Canonical, available under GPL" comments in the files, or
 b) put boilerplate saying it's copyright you, and some appropriate licence.

I don't know if (b) is an option.

review: Approve

« Back to merge proposal