Code review comment for lp:~johnf-inodes/bzr/serve-init

Revision history for this message
John A Meinel (jameinel) wrote :

# Specify startup options for bzr --serve

^- shouldn't that be "for bzr serve"

Also, shouldn't DAEMON_ARGS default to "serve --port..."

The way you have it written, seems like it will try to run:

 "bzr --port=127.0.0.0:4155"

Which wouldn't actually do anything.

So I think it needs a couple small tweaks, and it would probably be good to get this licensed as (c) Canonical if johnf doesn't object. (It makes managing the code base easier when we don't have to think again about the license. if it is a problem for johnf, then we can consider further.)

review: Needs Fixing

« Back to merge proposal