Code review comment for lp:~johnf-inodes/bzr/serve-init

On Thu, Oct 08, 2009 at 05:59:29PM -0000, John A Meinel wrote:
> Review: Needs Fixing
> # Specify startup options for bzr --serve
>
> ^- shouldn't that be "for bzr serve"

Nice catch. Pushed.

> Also, shouldn't DAEMON_ARGS default to "serve --port..."
>
> The way you have it written, seems like it will try to run:
>
> "bzr --port=127.0.0.0:4155"
>
> Which wouldn't actually do anything.

The init script does

    bzr serve $DAEMON_ARGS --directory $REPO

so it should o the right thing.

> So I think it needs a couple small tweaks, and it would probably be good to get this licensed as (c) Canonical if johnf doesn't object. (It makes managing the code base easier when we don't have to think again about the license. if it is a problem for johnf, then we can consider further.)

I'll sort that out shortly.

Cheers,
John

--
John
Blog http://www.inodes.org
LCA2010 http://www.lca2010.org.nz