Very good first shot at an Ibid module :-) Just a couple things though:
* I prefer to put imports into three groups (separated with a newline):
stdlib modules, other modules, and then Ibid modules.
* Does the grab regex only allow (com|org|net|za) TLDs? If so, it should
accept any URL. The current url plugin is very liberal in what it detects. It
might be an idea to capture anything which looks like a URL, but then
validate it in some way (check that domain exists for example).
* Don't catch exceptions unless they're expected errors and you're going to
do something useful with them. Ibid catches and logs exceptions raised by
plugins.
review needs_fixing
Very good first shot at an Ibid module :-) Just a couple things though:
* I prefer to put imports into three groups (separated with a newline):
stdlib modules, other modules, and then Ibid modules.
* Does the grab regex only allow (com|org|net|za) TLDs? If so, it should
accept any URL. The current url plugin is very liberal in what it detects. It
might be an idea to capture anything which looks like a URL, but then
validate it in some way (check that domain exists for example).
* Don't catch exceptions unless they're expected errors and you're going to
do something useful with them. Ibid catches and logs exceptions raised by
plugins.
review needs_fixing