Code review comment for lp:~jonathanjgster/ibid/jjg
Revision history for this message
| Stefano Rivera (stefanor) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Ah. Now that it's in URL, the username and password fields need to be renamed again. Sorry.
How about: delicious_username and delicious_password
Line 72 - should have spaces around the +
The obfusc section looks like it's very IRC specific. Have you tested with other protocols?
I don't think the try-except logic in _get_title is necessary. It goes against ibid-style (I make the same mistake all the time).
I'd put the delicious regexs inside the Delicious class.
Aside from that, no complaints. Will test it on hardy now.