Code review comment for lp:~jpds/launchpad/fix_196173

Hi Jonathan,

Thanks again for another mirror branch.

As we discussed on IRC there are some problems that need fixing and I know you've already started on some.

First, the newMirror method needs to add support for a whiteboard. That needs to be added to interface/distribution.py and model/distribution.py.
When adding a new optional argument to an existing method it is usually best to tack it onto the end. That way you don't break existing call sites.

The doctests for newMirror are in doc/distribution-mirror.txt. You'll need to update those to ensure the whiteboard is accepted and set properly. Since the permissions for that field changed you'll need tests to ensure registrants and admins can set the whiteboard.

There may be more work that needs to be done. But have a go at these issues and we'll take another pass.