Code review comment for lp:~jpds/launchpad/fix_50580

Revision history for this message
Michael Nelson (michael.nelson) wrote :

> Hi Jonathan,
>
> nice work, thanks for for this branch, and esepcially for adding the tests.
> Since this is a UI change, I'll ask one of the UI reviewer to have a look too.

Hi Jonathan,

Thanks for doing this! I've just merged it and taken a look locally, but there's only one mirror there with a known lastupdate. Just a thought for next time, it's helpful to either provide a script that populates the local db with suitable data to demo, or a screenshot etc.

Great!

review: Approve (ui)

« Back to merge proposal