Code review comment for lp:~jpds/launchpad/fix_50580

Revision history for this message
Guilherme Salgado (salgado) wrote :

On Fri, 2009-12-11 at 12:32 +0000, Michael Nelson wrote:
> Review: Approve ui
> > Hi Jonathan,
> >
> > nice work, thanks for for this branch, and esepcially for adding the tests.
> > Since this is a UI change, I'll ask one of the UI reviewer to have a look too.
>
> Hi Jonathan,
>
> Thanks for doing this! I've just merged it and taken a look locally,
> but there's only one mirror there with a known lastupdate. Just a
> thought for next time, it's helpful to either provide a script that
> populates the local db with suitable data to demo, or a screenshot
> etc.

Even better would be to add mirrors to the -dev sampledata. To do that
you can just create the mirrors on https://launchpad.dev and follow the
instructions on database/sampledata/README

--
Guilherme Salgado <email address hidden>

« Back to merge proposal